[PATCH] v8: fix missing callback in heap utils destroy
authorRuben Bridgewater <ruben.bridgewater@datadoghq.com>
Mon, 30 Jun 2025 11:51:40 +0000 (13:51 +0200)
committerJérémy Lal <kapouer@melix.org>
Tue, 24 Mar 2026 21:11:25 +0000 (22:11 +0100)
commitd8e4f909cbf46def087c133c29a9e6b9693d40f9
tree646eee7d7fa91293563c641594574d61d2be70b5
parent47edeff94f9429cb4b8096038967cf921f646ebc
[PATCH] v8: fix missing callback in heap utils destroy

This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: https://github.com/nodejs/node/pull/58846
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Gbp-Pq: Topic sec
Gbp-Pq: Name 19-v8-fix-missing-callback-in-heap-utils-destroy.patch
lib/internal/heap_utils.js
test/sequential/test-heapdump.js